Skip to content

Commit

Permalink
Mitigate version mismatch of public rustls dependency
Browse files Browse the repository at this point in the history 
PyO3/maturin#1671
  • Loading branch information
@kornelski @algesten
kornelski authored and algesten committed Sep 18, 2024
1 parent 11aed99 commit 8abb5c2
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/lib.rs
View file
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,18 @@
//! [actix-web](https://crates.io/crates/actix-web), and [hyper](https://crates.io/crates/hyper).
//!
/// Re-exported rustls crate
///
/// Use this re-export to always get a compatible version of `ClientConfig`.
#[cfg(feature = "rustls")]

Check failure on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Docs 

unexpected `cfg` condition value: `rustls`

Check failure on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Lint 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (charset) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (brotli) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (cookies) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (http-crate) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (http-interop) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (gzip) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (json) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, brotli) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-certs) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (http-crate http-interop) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, cookies) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, charset) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, http-interop) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, gzip) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, http-crate) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, json) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, native-certs) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, http-crate http-interop) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (socks-proxy) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (native-tls, socks-proxy) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, brotli) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, charset) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, gzip) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, http-interop) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, json) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, http-crate http-interop) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, http-crate) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, socks-proxy) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, native-certs) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / Test (tls, cookies) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / build_versions (beta) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / build_versions (beta) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / build_versions (stable) 

unexpected `cfg` condition value: `rustls`

Check warning on line 360 in src/lib.rs

View workflow job for this annotation

GitHub Actions / build_versions (stable) 

unexpected `cfg` condition value: `rustls`
pub use rustls;

/// Re-exported native-tls crate
///
/// Use this re-export to always get a compatible version of `TlsConnector`.
#[cfg(feature = "native-tls")]
pub use native_tls;

mod agent;
mod body;
mod chunked;
Expand Down

1 comment on commit 8abb5c2

@kolbma
Copy link

@kolbma kolbma commented on 8abb5c2 Sep 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no feature rustls in v2.x!

In other places of code you can also find the usage of tls-native, which is twisted of the available native-tls feature.
In such places the code doesn't work for native-tls, so I think it is best to remove the twisted feature check there!

Please sign in to comment.