Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Marker Annotation Unittest #76

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Added Marker Annotation Unittest #76

merged 1 commit into from
Sep 29, 2021

Conversation

Hunter-1
Copy link
Contributor

Added A Marker Annotation Unittest
Closes #60

RadikalJin
RadikalJin reviewed Sep 29, 2021
View reviewed changes
...c/test/java/org/alfasoftware/astra/core/refactoring/annotations/TestAnnotationsRefactor.java
t instanceof TypeDeclaration && AstraUtils.getFullyQualifiedName((TypeDeclaration) t)
.equals(AddMarkerAnnotationExample.class.getName()))
.withAnnotationName("AnnotationA")
.withOptionalAnnotationMember("")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here

@RadikalJin
Copy link
Member

Hello @Hunter-1, and thank you for your contribution to Astra.
This is excellent. Could we expand this further by avoiding calling withOptionalAnnotationMember(""), so that the annotation is added without the braces? This could either be a separate test or we could update the one you've already written here.

@RadikalJin RadikalJin merged commit 1b8d183 into alfasoftware:main Sep 29, 2021
@Hunter-1
Copy link
Contributor Author

Hello @Hunter-1, and thank you for your contribution to Astra. This is excellent. Could we expand this further by avoiding calling withOptionalAnnotationMember(""), so that the annotation is added without the braces? This could either be a separate test or we could update the one you've already written here.

Yes, that's fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RadikalJin RadikalJin RadikalJin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add test for adding marker annotation in TestAnnotationsRefactor
2 participants
@Hunter-1 @RadikalJin