Fix/issue 104 reduce cognitive complexity #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 22, 2022 18:16
…ed to return value or null
|
Hello @mohannaidu, and thank you for your contribution to Astra. The changes are looking good - definitely helps to make the function simpler and easier to understand. Just a couple of suggestions:
After that I think we’re good to go. |
renamed processNode as updateNextChainedMethod
|
Hi @RadikalJin No problem. I have the changes as below:
Let me know you need anything else and I am happy to look into it. |
|
Looks great, thank you @mohannaidu! Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #104
Change proposed in this PR:
• have extracted processing of methodinvocation node to new method
• refactored new method to return value or null instead of continue or break.