[REFACTOR] Remove old Low-level Visitor/Mutator (apache#4612)

alexwong · Feb 28, 2020 · a0f51fe · a0f51fe
1 parent 8bb4314
commit a0f51fe
Show file tree

Hide file tree

Showing 10 changed files with 24 additions and 1,162 deletions.
diff --git a/include/tvm/ir_mutator.h b/include/tvm/ir_mutator.h
diff --git a/include/tvm/ir_visitor.h b/include/tvm/ir_visitor.h
diff --git a/src/autotvm/feature_visitor.h b/src/autotvm/feature_visitor.h
@@ -51,12 +51,12 @@ enum AnnotationType {
 class FeatureVisitor : public StmtExprVisitor {
  public:
   // for loop
-  void VisitStmt_(const For *op);
-  void VisitStmt_(const AttrStmt *op);
+  void VisitStmt_(const For* op) final;
+  void VisitStmt_(const AttrStmt* op) final;
 
   // memory access
-  void VisitExpr_(const Load *op);
-  void VisitStmt_(const Store *op);
+  void VisitExpr_(const Load* op) final;
+  void VisitStmt_(const Store* op) final;
 
   using StmtExprVisitor::VisitStmt_;
   using StmtExprVisitor::VisitExpr_;

diff --git a/src/autotvm/touch_extractor.cc b/src/autotvm/touch_extractor.cc
@@ -51,7 +51,7 @@ class IndexParser: public ExprVisitor {
     this->VisitExpr(expr);
   }
 
-  void VisitExpr_(const Variable *op) {
+  void VisitExpr_(const Variable* op) final {
     // TODO(lmzheng): handle more index types (multiple occurrence)
     if (pattern_map.count(op) == 0) {
       pattern_map[op] = TouchPattern();
@@ -60,7 +60,7 @@ class IndexParser: public ExprVisitor {
     }
   }
 
-  void VisitExpr_(const Mul *op) {
+  void VisitExpr_(const Mul* op) final {
     if (op->a.as<Variable>()) {
       if (const auto stride = op->b.as<IntImm>()) {
         next_stride_ = stride->value;

diff --git a/src/autotvm/touch_extractor.h b/src/autotvm/touch_extractor.h
@@ -90,31 +90,31 @@ class TouchExtractor : public FeatureVisitor {
   }
 
   // arithmetic stats
-  void VisitExpr_(const Add *op) {
+  void VisitExpr_(const Add* op) final {
     if (op->dtype.is_float())
       itervar_map[itervar_stack_.back()].add_ct++;
     FeatureVisitor::VisitExpr_(op);
   }
 
-  void VisitExpr_(const Sub *op) {
+  void VisitExpr_(const Sub* op) final {
     if (op->dtype.is_float())
       itervar_map[itervar_stack_.back()].add_ct++;
     FeatureVisitor::VisitExpr_(op);
   }
 
-  void VisitExpr_(const Mul *op) {
+  void VisitExpr_(const Mul* op) final {
     if (op->dtype.is_float())
       itervar_map[itervar_stack_.back()].mul_ct++;
     FeatureVisitor::VisitExpr_(op);
   }
 
-  void VisitExpr_(const Div *op) {
+  void VisitExpr_(const Div* op) final {
     if (op->dtype.is_float())
       itervar_map[itervar_stack_.back()].div_ct++;
     FeatureVisitor::VisitExpr_(op);
   }
 
-  void VisitExpr_(const Mod *op) {
+  void VisitExpr_(const Mod* op) final {
     if (op->dtype.is_float())
       itervar_map[itervar_stack_.back()].div_ct++;
     FeatureVisitor::VisitExpr_(op);