Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix classpath inject warning by moving PreferencesProto out of superclass hierarchy for PreferencesDataStore #2320

Merged
merged 7 commits into from
Jan 18, 2025

Conversation

alexvanyo
Copy link
Owner

No description provided.

@alexvanyo alexvanyo enabled auto-merge (rebase) January 18, 2025 01:26
Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.37%. Comparing base (93bc972) to head (d077c71).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2320      +/-   ##
============================================
- Coverage     63.38%   63.37%   -0.01%     
- Complexity      517      518       +1     
============================================
  Files           237      237              
  Lines         12499    12499              
  Branches       2217     2217              
============================================
- Hits           7922     7921       -1     
  Misses         3389     3389              
- Partials       1188     1189       +1     
Flag Coverage Δ
21 63.37% <100.00%> (ø)
23 ?
24 ?
25 ?
26 ?
27 ?
28 ?
29 ?
30 ?
31 ?
32 ?
33 ?
34 ?
35 63.36% <100.00%> (ø)
unit 63.37% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexvanyo alexvanyo merged commit 7f771ad into main Jan 18, 2025
21 checks passed
@alexvanyo alexvanyo deleted the av/fix-classpath-inject-warning branch January 18, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant