Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fancy drag and drop for cell state #2280

Merged
merged 2 commits into from
Dec 28, 2024
Merged

Conversation

alexvanyo
Copy link
Owner

@alexvanyo alexvanyo commented Dec 26, 2024

Fixes #1940 and fixes #1941

Screen_recording_20241227_173929.webm

Copy link

codecov bot commented Dec 27, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
15977 1 15976 0
View the full list of 1 ❄️ flaky tests
com.alexvanyo.composelife.ui.app.action.LoadedCellStatePreviewTests drag_and_drop_works_correctly

Flake rate in main: 21.74% (Passed 18 times, Failed 5 times)

Stack Traces | 0.548s run time
java.lang.AssertionError: expected:<CellStateImpl([(2, 0), (0, 1), (2, 1), (1, 2), (2, 2)])> but was:<null>
	at org.junit.Assert.fail(Assert.java:89)
	at org.junit.Assert.failNotEquals(Assert.java:835)
	at org.junit.Assert.assertEquals(Assert.java:120)
	at kotlin.test.junit.JUnitAsserter.assertEquals(JUnitSupport.kt:32)
	at kotlin.test.AssertionsKt__AssertionsKt.assertEquals(Assertions.kt:63)
	at kotlin.test.AssertionsKt.assertEquals(Unknown Source)
	at kotlin.test.AssertionsKt__AssertionsKt.assertEquals$default(Assertions.kt:62)
	at kotlin.test.AssertionsKt.assertEquals$default(Unknown Source)
	at com.alexvanyo.composelife.ui.app.action.LoadedCellStatePreviewTests$drag_and_drop_works_correctly$1.invokeSuspend(LoadedCellStatePreviewTests.kt:171)
	at com.alexvanyo.composelife.ui.app.action.LoadedCellStatePreviewTests$drag_and_drop_works_correctly$1.invoke(LoadedCellStatePreviewTests.kt)
	at com.alexvanyo.composelife.ui.app.action.LoadedCellStatePreviewTests$drag_and_drop_works_correctly$1.invoke(LoadedCellStatePreviewTests.kt)
	at com.alexvanyo.composelife.test.BaseUiInjectTest_androidKt$runUiTest$1$1.invokeSuspend(BaseUiInjectTest.android.kt:45)
	at com.alexvanyo.composelife.test.BaseUiInjectTest_androidKt$runUiTest$1$1.invoke(BaseUiInjectTest.android.kt)
	at com.alexvanyo.composelife.test.BaseUiInjectTest_androidKt$runUiTest$1$1.invoke(BaseUiInjectTest.android.kt)
	at com.alexvanyo.composelife.test.BaseInjectTest$runAppTest$1.invokeSuspend(BaseInjectTest.kt:58)
	at com.alexvanyo.composelife.test.BaseInjectTest$runAppTest$1.invoke(BaseInjectTest.kt)
	at com.alexvanyo.composelife.test.BaseInjectTest$runAppTest$1.invoke(BaseInjectTest.kt)
	at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$2$1$1.invokeSuspend(TestBuilders.kt:318)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.test.TestDispatcher.processEvent$kotlinx_coroutines_test(TestDispatcher.kt:24)
	at kotlinx.coroutines.test.TestCoroutineScheduler.tryRunNextTaskUnless$kotlinx_coroutines_test(TestCoroutineScheduler.kt:99)
	at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt$runTest$2$1$workRunner$1.invokeSuspend(TestBuilders.kt:327)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:101)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:263)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:95)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:69)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:47)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
	at kotlinx.coroutines.test.TestBuildersJvmKt.createTestResult(TestBuildersJvm.kt:10)
	at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest-8Mi8wO0(TestBuilders.kt:310)
	at kotlinx.coroutines.test.TestBuildersKt.runTest-8Mi8wO0(Unknown Source)
	at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest-8Mi8wO0(TestBuilders.kt:168)
	at kotlinx.coroutines.test.TestBuildersKt.runTest-8Mi8wO0(Unknown Source)
	at kotlinx.coroutines.test.TestBuildersKt__TestBuildersKt.runTest-8Mi8wO0$default(TestBuilders.kt:160)
	at kotlinx.coroutines.test.TestBuildersKt.runTest-8Mi8wO0$default(Unknown Source)
	at com.alexvanyo.composelife.test.BaseInjectTest.runAppTest(BaseInjectTest.kt:50)
	at com.alexvanyo.composelife.test.BaseUiInjectTest_androidKt.runUiTest$lambda$0(BaseUiInjectTest.android.kt:44)
	at com.alexvanyo.composelife.test.BaseUiInjectTest_androidKt.$r8$lambda$Xb2JZd7Lp-CV1D0kbm0Z781AQnQ(BaseUiInjectTest.android.kt)
	at com.alexvanyo.composelife.test.BaseUiInjectTest_androidKt$$ExternalSyntheticLambda0.invoke(D8$$SyntheticClass:0)
	at androidx.compose.ui.test.ComposeUiTest_androidKt$runAndroidComposeUiTest$1.invoke(ComposeUiTest.android.kt:114)
	at androidx.compose.ui.test.ComposeUiTest_androidKt$runAndroidComposeUiTest$1.invoke(ComposeUiTest.android.kt:112)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment$AndroidComposeUiTestImpl.withDisposableContent(ComposeUiTest.android.kt:585)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment$runTest$1$1$1$1$1$1.invoke(ComposeUiTest.android.kt:372)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment.withComposeIdlingResource(ComposeUiTest.android.kt:441)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment.access$withComposeIdlingResource(ComposeUiTest.android.kt:237)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment$runTest$1$1$1$1$1.invoke(ComposeUiTest.android.kt:371)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment.withWindowRecomposer(ComposeUiTest.android.kt:415)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment.access$withWindowRecomposer(ComposeUiTest.android.kt:237)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment$runTest$1$1$1$1.invoke(ComposeUiTest.android.kt:370)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment.withTestCoroutines(ComposeUiTest.android.kt:428)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment.access$withTestCoroutines(ComposeUiTest.android.kt:237)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment$runTest$1$1$1.invoke(ComposeUiTest.android.kt:369)
	at androidx.compose.ui.test.EspressoLink.withStrategy(EspressoLink.android.kt:69)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment$runTest$1$1.invoke(ComposeUiTest.android.kt:368)
	at androidx.compose.ui.test.IdlingResourceRegistry.withRegistry(IdlingResourceRegistry.jvm.kt:146)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment$runTest$1.invoke(ComposeUiTest.android.kt:367)
	at androidx.compose.ui.test.ComposeRootRegistry.withRegistry(ComposeRootRegistry.android.kt:137)
	at androidx.compose.ui.test.AndroidComposeUiTestEnvironment.runTest(ComposeUiTest.android.kt:366)
	at androidx.compose.ui.test.ComposeUiTest_androidKt.runAndroidComposeUiTest(ComposeUiTest.android.kt:112)
	at com.alexvanyo.composelife.test.BaseUiInjectTest_androidKt.runUiTest(BaseUiInjectTest.android.kt:58)
	at com.alexvanyo.composelife.ui.app.action.LoadedCellStatePreviewTests.drag_and_drop_works_correctly(LoadedCellStatePreviewTests.kt:70)

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@alexvanyo alexvanyo force-pushed the av/cell-state-drop-state branch from ea6770c to 9c58041 Compare December 27, 2024 23:06
@alexvanyo alexvanyo marked this pull request as ready for review December 27, 2024 23:11
@alexvanyo alexvanyo enabled auto-merge (rebase) December 27, 2024 23:11
@alexvanyo alexvanyo force-pushed the av/cell-state-drop-state branch from 9c58041 to 09d275a Compare December 28, 2024 00:38
@alexvanyo alexvanyo force-pushed the av/cell-state-drop-state branch from 09d275a to e9da84b Compare December 28, 2024 00:56
@alexvanyo alexvanyo merged commit aa55e99 into main Dec 28, 2024
18 of 23 checks passed
@alexvanyo alexvanyo deleted the av/cell-state-drop-state branch December 28, 2024 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Center dropped cell state on release point Preview dropping cell state selection
1 participant