-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: #1081 Add a way to hide unneeded form fields from clients #1082
Feature: #1081 Add a way to hide unneeded form fields from clients #1082
Conversation
I've now finished all tasks to make this feature function. The translations that I've added are automatically translated. I don't know what the official process for this is for this repository. So the translations are not perfect. In fact, I think "Client Form" may have been translated to mean "the state in which the client is/how the client looks" instead of "the form that the client can fill in". The eye icons have been picked from here: https://www.iconfinder.com/icons/314276/hidden_eye_icon. It seems that the license allows us to use these icons. Attribution would be nice but not necessary. I wouldn't know where to add this attribution. Also, before using this you may need to update your database by going to http:///backend/update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested your PR and I really liked it!
Congratulations on your contribution to the project!
As I need to run Easy!Appointments with the PR I also made, I've already merged your PR into my develop branch. I identified a problem running the npm start
command when building the front, which I solved with the suggestions I requested here in your PR
Apply suggestions from @vitormattos. Co-authored-by: Vitor Mattos <[email protected]>
Hi @vitormattos, Thanks for the review and the changes. I've committed and implemented them. Let's hope we can merge soon then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you think of this change?
@Tthecreator i think you need to review @vitormattos last suggestion? @alextselegidis any chance we can merge this finally? Thanks! |
Greetings! Thanks for this PR! I'm currently undergoing the PR merging phase so this will be reviewed soon. FYI the settings page will be completely reworked, so chances are that the user interface will change drastically. In one way or the other, 1.5 will allow you to select which fields to display to the booking page.
|
Co-authored-by: Vitor Mattos <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still seems to work after merge
I accepted the changes by @vitormattos. Not sure how I forgot about those, but here we are anyways. I think this PR is now ready for final review. What do you suggest with the drastic UI changed @alextselegidis, still merge this? |
@Tthecreator More setting capabilities need to be added to the settings page and we cannot always add tabs to the form. For that a different menu structure and rendering will be prepared. This is where the will be some incompatibility, but before I proceed of the new markup, I will partially merge your solution so that the field toggling works.
|
This is my pull request portraying to issue #1081.
So far I've: