-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make sure the booking cancellation is a post request and has a reason value provided. #1178
Comments
Hello! Thanks for reaching out for such an important issue.
How did the bot parse your received email at the first place? FYI the public booking URLs are using random hash strings that are hard for a bot to guess just by randomly trying.
|
Hello ! The customer who received this email notification is using some kind of virus-scanner or malware scanner that automatically scans included URLs of the email message. Therefore the URL was known to the bot. I think it should be enough to check for the reason of cancellation and if not present just ignore the GET call. |
Hello! Thanks for writing back on this issue. Just checking for the reason would not be sufficient as bots may provide dummy reason content as well. Additionally the cancellation link is not part of the email (only the rescheduling link is) which means that unless there's a malware that can target only such emails, there is no way they figured out the cancellation URL from the email. Did this issue happen again?
|
Hello, the issue is the following: I don't think virus-scanners will POST forms or even fill out parameters. Therefore I think just making sure that either the METHOD is correct or a reason is given is better than current. |
Hello! You are right, an additional protection step is required as cancellations may also happen accidentally as well. Let me mark this for 1.5 🚀 Star and follow the projects to receive regular development updates.
|
Hello,
we discovered an issue where an appointment is sent via email to the customer and some kind of bot crawled the appointment details page afterwards (pishing scan or whatever). It looks like the crawler then fetched /appointment/cancel/ID and the appointment got cancelled without even an email to the customer or provider.
This is reproducible by just visiting the form action in the appointment details page.
The text was updated successfully, but these errors were encountered: