Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service duration values shorter than 5 minutes should be acceptable via the services page. #1110

Closed
h-e-l-l-o-w-o-r-l-d opened this issue Aug 23, 2021 · 4 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@h-e-l-l-o-w-o-r-l-d
Copy link

Hi,

while #1068 is solved, I cannot set service durations < 5 in backend, see screenshot. There is a error message on save with no text inside.

Setting in /application/config/constants.php -> define('EVENT_MINIMUM_DURATION', 4);

ea

@alextselegidis
Copy link
Owner

Hello @h-e-l-l-o-w-o-r-l-d,

Yes, right now and due to performance reasons the minimum service duration is 5 minutes.

You can easily change that by changing the value of the corresponding variable in the constants.php file:

https://github.com/alextselegidis/easyappointments/blob/master/application/config/constants.php#L90

Hope that helps!

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Get a free quote!

@h-e-l-l-o-w-o-r-l-d
Copy link
Author

I'm sorry but like written in the description the value in constants.php is already set to 4 but value 4 is not accepted when creating a new service in the backend.

@alextselegidis
Copy link
Owner

That's because of this line:

https://github.com/alextselegidis/easyappointments/blob/master/assets/js/backend_services_helper.js#L287

Change it to 4 or less and it'll work.

I will need to make this magic number also originate from the constant, so I'm marking this as a bug ticket.

  Alex Tselegidis, Easy!Appointments Creator
  Need a customization? Get a free quote!

@alextselegidis alextselegidis self-assigned this Aug 27, 2021
@alextselegidis alextselegidis added the bug Something isn't working label Aug 27, 2021
@alextselegidis alextselegidis added this to the v1.5.0 milestone Aug 27, 2021
@h-e-l-l-o-w-o-r-l-d
Copy link
Author

Related to #1068

Same problem...

Created a patch for now to solve this. Thanks!

@alextselegidis alextselegidis changed the title Cannot set service duration < 5 in backend Cannot set service duration to be less than 5 minutes in the services page. Oct 22, 2021
@alextselegidis alextselegidis changed the title Cannot set service duration to be less than 5 minutes in the services page. Service duration values shorter than 5 minutes should be acceptable via the services page. Oct 22, 2021
alextselegidis added a commit that referenced this issue Jan 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants