Fix dotnet core 2 branch #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hartmannr76
commented
Aug 28, 2017
| @@ -11,6 +11,7 @@ ENV DOTNET_USE_POLLING_FILE_WATCHER 1 | |||
| # WORKDIR /app | |||
| RUN mkdir /app | |||
| COPY ./src/*.csproj /app | |||
| COPY ./Directory.Build.props / | |||
There was a problem hiding this comment.
This is needed for restore and I chose to dump at the root
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@alexsandro-xpt
From my findings, the root cause of this issue was due to changing the
BaseIntermediateOutputPathin a csproj. Seems that this break is intended functionality, and props like this more appropriately belong in apropsfile. Discovered issueThere is another workaround you can do directly in the csproj file, but I don't think that is repeatable. At least with this, if you wanted to pull down from a curl request or something, its less overhead to setup.
The
_WatchTargetstuff is something I found also as an issue with watcher in regards to output path changing, and implemented the fix.Let me know your thoughts.