Prevent PositionableAbility.targetPosition from being set to 0% or 100% unless the Shelly has been manually controlled #325
Conversation
|
The current debounce algorithm would prefer older target position updates over newer ones. This would lead to HomeKit getting out sync when changing the target position too quickly. |
|
@alexryd - any chance that this could be merged? Simple change but helps a lot with consistency in Home app. Happy to help with testing if needed. |
|
@alexryd - Any updates? |
|
Almost one year later and this is not merged. This is a literal life-saver of a PR, it's needed if you want a good experience with Shelly roller shutters on HB. Any chance this might get merged? @alexryd |
|
@alexryd is that plugin still supported? If not then we would need to change for a one which still has a proper lifecycle. Thanks. |
|
Still no updates? Oh come on |
|
Not sure if it helps but I moved to https://github.com/mongoose-os-apps/shelly-homekit Even though I have 12 Shelly 2.5 as shutters it was still worth it. |
After specifying a target position using the Home app, the slider would automatically jump to 0 or 100 (depending on wether it was moving up or down) until the Shelly stopped moving. This pull request changes this behavior. Now the target position only gets set to 0 / 100 if the user manually controls the Shelly using either the Shelly app or a physical button.