Implemented more common check_mk agent sections #4
Conversation
of ps is somewhat limited to the capabilities to the ps command of busybox for which conversion routines might be a solution in future. But for the moment this should be enough to actually monitor if a certain process is running or not.
…spberryMatic compatibility)
also added to the check_mk output as well as the trip_point limits defined by the hardware.
to the check_mk agent execution. Also implemented nfsmounts and cifsmounts outputs using waitmax.
|
Thanks for the PR. |
|
Then feel free to remove the waitmax use from the PR. Or reconsider changing the license of your Addon to GPLv2 itself or add the waitmax sources to your repository to show that you haven't changed anything. |
…erryMatic versions will use chrony instead of NTPd.
should provide the same functionality but is licensed under GPL3 which is compatible to Apache2.
|
@alexreinert Please note that with the latest commit I retired |
|
The linked page states, that this direction is not possible. Only GPL license, which would be compatible in that way, would be the LGPL. And I will not include binaries in my repositories, where I do not know, how they are build. (Because of security AND because of support) |
'timeout' command (e.g. on RaspberryMatic) or to use shell syntax to replicate the same functionality just using shell functionality. This should hopefully solve any licensing issues between GPL and Apache2 license under which this check_mk_agent is licensed.
|
Woooh. Ok, I definitely overlooked that final sentence. Never mind, I just introduced a replacement wrapper script in my last commit (see fcc773b) and explicitly licensed it under Apache2.0 for your convenience. This hopefully should solve your license concerns while at the same time provide a reliable |
|
Looks better now, thanks. |
'timeout' command syntax where the time to wait is supplied via a second argument rather than a "-t" option.
informational messages.
|
any progress here? I would like to finished this PR and get my fork cleanup up accordingly. Would be nice to see this PR finally integrated. Here it is working stable since then |
This PR implements:
timeoutwrapper script to securetcp_conn_statsandchrony/ntpexecutions which could hang otherwise<<<nfsmounts>>>and<<<cifsmounts>>>sections if/bin/statexists and waitmax is there.<<<lnx_thermal>>>check_mk output to add all existing thermal zones actually existing and not just thermal_zone0/VERSIONrather than/boot/VERSIONto query the firmware version if/VERSIONexists (which is the preferred way for CCU3/RaspberryMatic).