Upgrade to AWS SDK v2 #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #23
I took a stab at this, but pretty quickly lost interest. Upgrading the library code was straightforward, and it likely works now, but the tests are much harder. The test client requires all sorts of configuration tweaks to work with s3proxy and I don't know how to do that in the new version. If someone who knows more about this stuff could make the tests run, that'd be great. I don't even write Java these days.
In general the tests are hacky and could use an overhaul. There may be much better local S3 alternatives for this purpose than s3proxy. They also have poor coverage.