fix: unsubscribe from decorator when the object is destroyed

alexlafroscia · Feb 5, 2019 · 1abd5fb · 1abd5fb
1 parent e96d160
commit 1abd5fb
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 1 deletion.
diff --git a/addon/decorators/subscribe.js b/addon/decorators/subscribe.js
@@ -69,7 +69,7 @@ export default function subscribe(observableKey) {
           }
 
           willDestroy() {
-            this.removeListener(observableKey, this, resetSubscription);
+            this.removeObserver(observableKey, this, resetSubscription);
 
             if (this[SUBSCRIPTION]) {
               this[SUBSCRIPTION].unsubscribe();

diff --git a/tests/unit/decorators/subscribe-test.js b/tests/unit/decorators/subscribe-test.js
@@ -129,5 +129,26 @@ module("Unit | Decorator | subscribe", function(hooks) {
         );
       });
     });
+
+    test("it un-subscribes when the object is destroyed", function(assert) {
+      this.scheduler.run(helpers => {
+        const i = SomeClass.create({
+          observable: helpers.cold("--a--b", {
+            a: 1,
+            b: 2
+          })
+        });
+
+        this.scheduler.flush();
+
+        i.willDestroy();
+
+        assert.equal(
+          i.observable.subscriptions[0].unsubscribedFrame,
+          5,
+          "Unsubscribed from the observable"
+        );
+      });
+    });
   });
 });