Fix permissions issues with S6 Overlay 3.x #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexjustesen
approved these changes
Oct 6, 2022
|
Hell yeah @jaydrogers, thanks a ton for looking into this and glad I could help (somewhat) commit to improving the base images too! |
1 task
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
webuser(important for PHP commands + Laravel)Things to test
/app/config.ymlworks well. I had to require "root" to copy this overGreat work @alexjustesen!
My last PR had a ton of improvements and suggestions, but then I realized I was on the wrong friggen branch 😆
When I switched to the correct branch, you already had almost all of my suggestions done 🥳
Keep up the great work!