Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Refactor InfluxDB integration + add bulk import results (⚠️ breaking change) #1866

Merged
merged 17 commits into from
Dec 4, 2024

Conversation

alexjustesen
Copy link
Owner

@alexjustesen alexjustesen commented Dec 2, 2024

⚠️ This is a breaking change for the Influxdb integration, you'll want to use the new feature to re-load your history.

📃 Description

This PR expands on the work in #1802 and provides additional hooks into the speedtest process. This PR also cleans up the tags and fields to clearly define them as:

  • Tags are qualitative (non-numerical) data. Example: service, isp and server_id.
  • Fields are quantitative (numerical) data. Example: download, upload and ping.

This PR introduces a regression which has been logged in #1878.

🪵 Changelog

➕ Added

  • import full history to Influxdb
  • tags: external_ip, server_country, server_location, healthy and service.

✏️ Changed

  • moved app_name, result_id, isp, scheduled and status to tags.
  • renamed id to result_id.

🔧 Fixed

  • field data type issues where int/float would sometimes be written as strings.

🗑️ Removed

  • tags: server_host

@alexjustesen alexjustesen added the 🎉 feature New feature or request label Dec 2, 2024
@alexjustesen alexjustesen self-assigned this Dec 2, 2024
@alexjustesen alexjustesen mentioned this pull request Dec 2, 2024
4 tasks
@alexjustesen alexjustesen changed the title [Feature] Refactor InfluxDB integration [Feature] Refactor InfluxDB integration (⚠️ breaking change) Dec 4, 2024
@alexjustesen alexjustesen changed the title [Feature] Refactor InfluxDB integration (⚠️ breaking change) [Feature] Refactor InfluxDB integration + add bulk import results (⚠️ breaking change) Dec 4, 2024
@alexjustesen alexjustesen marked this pull request as ready for review December 4, 2024 21:32
@alexjustesen alexjustesen merged commit 7348f06 into main Dec 4, 2024
1 check passed
@alexjustesen alexjustesen deleted the refactor-influxdb-integration branch December 4, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants