-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #1759
Update README.md #1759
Conversation
Add: schedule variable, as it is a feature most people are gonna want to customize
Just my 2 cents; |
That is a good point. I suppose it doesn't really matter what it is set to originally, personally i trigger a speedtest every 15 minutes. |
For most it will be fine, but it might be weird if we suggest this schedule and then later advice not to do that 😅 |
Yeah honestly. I just wanted to have this added to the readme so that new users are aware that this is customizable. I don't know how many days/weeks i spent troubleshooting this, at some point i considered triggering the speedtest myself and just appending the data to database, but thankfully i found that environment variable hehe.
How about we can default something like |
I do agree that adding it is a good idea.
|
@Kristoffeh I'm happy to add the option in but can you comment the line out so it's "disabled" by default with no schedule suggestion? |
- SPEEDTEST_SCHEDULE: Environment variable disabled by default - SPEEDTEST_SCHEDULE: Removed cron job suggestion
Awesome, thanks guys. I'm honestly surprised by the response times here. Its a great project you guys got going on, keep it up <3 |
Add: schedule variable, as it is a feature most people are gonna want to customize
📃 Description
Most people are going to want to customize how often a speedtest is triggered. For several days I considered forking this and implementing it myself, until i found out it was already possible. The primary focus of this change is to easily show newcomers that it is indeed possible.
🪵 Changelog
✏️ Changed
SPEEDTEST_SCHEDULE
toREADME.MD
(defaults to 1 hour).