Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Notification] Change Ntfy, Gotify, Pushover from Webhook to framework #1723

Closed
wants to merge 22 commits into from
Closed

[Notification] Change Ntfy, Gotify, Pushover from Webhook to framework #1723

wants to merge 22 commits into from

Conversation

svenvg93
Copy link
Contributor

@svenvg93 svenvg93 commented Sep 23, 2024 •
edited
Loading

📃 Description

This PR changes Ntfy, Gotify, Pushover, to use a framework instead of Web hooks.

🪵 Changelog

➕ Added

✏️ Changed

  • Switch ntfy to use markdown for the layout.
  • Switch pushover to use html for the layout

📷 Screenshots

If this PR has any UI/UX changes it's strongly suggested you add screenshots here.

svenvg93 added 18 commits August 5, 2024 23:01
@svenvg93 svenvg93 changed the title [Notification] Change ntfy & Gotify to Framework instead of webhook [Notification] Change from Webhook to framwork Sep 25, 2024
@svenvg93 svenvg93 marked this pull request as draft September 25, 2024 12:02
@svenvg93 svenvg93 changed the title [Notification] Change from Webhook to framwork [Notification] Change from Webhook to framework Sep 25, 2024
@svenvg93 svenvg93 marked this pull request as ready for review September 25, 2024 13:33
@svenvg93 svenvg93 changed the title [Notification] Change from Webhook to framework [Notification] Change Ntfy, Gotify, Pushover from Webhook to framework Sep 25, 2024
@svenvg93
Copy link
Contributor Author

Close, because of rework first.

@svenvg93 svenvg93 closed this Nov 26, 2024
@svenvg93 svenvg93 deleted the refactor/notifications branch November 27, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjustesen alexjustesen Awaiting requested review from alexjustesen alexjustesen is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow using NTFY with access tokens
1 participant
@svenvg93