Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix value rounding #1550

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Fix value rounding #1550

merged 3 commits into from
Jun 21, 2024

Conversation

svenvg93
Copy link
Contributor

📃 Description

To close #1545

🪵 Changelog

In the results tables and pop up view:

  • Round up the Packet loss with 2 and add a %
  • Round up the Upload and Download latency with 0 and add ms
  • Round up the Ping with 0 and add ms

📷 Screenshots

Before:

Scherm­afbeelding 2024-06-19 om 17 22 58 Scherm­afbeelding 2024-06-19 om 17 23 04

After

Scherm­afbeelding 2024-06-19 om 18 05 46 Scherm­afbeelding 2024-06-19 om 18 06 32

@alexjustesen alexjustesen merged commit f03c250 into alexjustesen:main Jun 21, 2024
1 check passed
@svenvg93 svenvg93 deleted the 1545-fix-rounding branch June 22, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjustesen alexjustesen alexjustesen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maybe a cli or tracker bug
2 participants
@svenvg93 @alexjustesen