Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Made checking for internet connection optional #1507

Merged
merged 1 commit into from
Jun 9, 2024
Merged

[Feature] Made checking for internet connection optional #1507

merged 1 commit into from
Jun 9, 2024

Conversation

alexjustesen
Copy link
Owner

@alexjustesen alexjustesen commented Jun 9, 2024 •
edited
Loading

📃 Description

This PR makes checking for an internet connection optional. If SPEEDTEST_PING_URL is false, empty or null it will skip the check.

closes #1501

🪵 Changelog

✏️ Changed

  • made checking for internet connection before a speedtest optional

@alexjustesen alexjustesen added the 🎉 feature New feature or request label Jun 9, 2024
@alexjustesen alexjustesen self-assigned this Jun 9, 2024
@alexjustesen alexjustesen merged commit a92e2a2 into main Jun 9, 2024
1 check passed
@alexjustesen alexjustesen deleted the check-for-internet-connection-optional branch June 9, 2024 14:54
@alexjustesen alexjustesen mentioned this pull request Jun 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexjustesen alexjustesen

Labels
🎉 feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

new install v0.20.3 -> Could not resolve host.
1 participant
@alexjustesen