Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Use ping instead of a HTTP get request to check for internet connection #1493

Merged
merged 4 commits into from
Jun 8, 2024
Merged

[Feature] Use ping instead of a HTTP get request to check for internet connection #1493

merged 4 commits into from
Jun 8, 2024

Conversation

alexjustesen
Copy link
Owner

@alexjustesen alexjustesen commented Jun 8, 2024 •
edited
Loading

📃 Description

This PR uses ping to check for internet connections instead of HTTP get requests.

closes #1484

🪵 Changelog

➕ Added

  • SPEEDTEST_PING_URL environment variable

✏️ Changed

  • use ping instead of http get

@alexjustesen alexjustesen added the 🎉 feature New feature or request label Jun 8, 2024
@alexjustesen alexjustesen added this to the v0.20.x milestone Jun 8, 2024
@alexjustesen alexjustesen self-assigned this Jun 8, 2024
@alexjustesen alexjustesen linked an issue Jun 8, 2024 that may be closed by this pull request
0.20.1: Could not resolve host. #1484
Closed
@alexjustesen
Copy link
Owner Author

@svenvg93 pinging you (pun intended) as this adds a new dependency to the dev image.

@alexjustesen alexjustesen merged commit 24efee2 into main Jun 8, 2024
1 check passed
@alexjustesen alexjustesen deleted the 1484-0201-could-not-resolve-host branch June 8, 2024 12:32
@alexjustesen alexjustesen mentioned this pull request Jun 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexjustesen alexjustesen

Labels
🎉 feature New feature or request
Projects
None yet
Milestone
v0.20.x
Development

Successfully merging this pull request may close these issues.

0.20.1: Could not resolve host.
1 participant
@alexjustesen