Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript translator #1

Merged
merged 18 commits into from
Jul 28, 2022
Merged

Typescript translator #1

merged 18 commits into from
Jul 28, 2022

Conversation

alexisthedev
Copy link
Owner

No description provided.

@alexisthedev alexisthedev requested a review from theosotr July 25, 2022 15:55
Copy link
Collaborator

@theosotr theosotr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

Most of the comments are related to stylish issues.
Follow the PEP8 guidelines when writing code (https://peps.python.org/pep-0008/).

Consider running PEP8-compliant linter for automatically resolving all style violations.

src/args.py Outdated Show resolved Hide resolved
src/ir/typescript_types.py Outdated Show resolved Hide resolved
src/ir/typescript_types.py Outdated Show resolved Hide resolved
src/ir/typescript_types.py Show resolved Hide resolved
src/ir/typescript_types.py Outdated Show resolved Hide resolved
src/translators/typescript.py Outdated Show resolved Hide resolved
src/translators/typescript.py Outdated Show resolved Hide resolved
src/translators/typescript.py Outdated Show resolved Hide resolved
src/translators/typescript.py Outdated Show resolved Hide resolved
src/translators/typescript.py Outdated Show resolved Hide resolved
@alexisthedev alexisthedev force-pushed the typescript-translator branch from fdd3d44 to 47098e7 Compare July 28, 2022 14:07
@alexisthedev alexisthedev force-pushed the typescript-translator branch from 47098e7 to 44b30ed Compare July 28, 2022 14:07
@theosotr theosotr merged commit a9ea560 into main Jul 28, 2022
@alexisthedev alexisthedev deleted the typescript-translator branch July 28, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants