Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generation process fails if asset contains any sizes without icons #1

Closed
iKenndac opened this issue Jun 12, 2017 · 2 comments
Closed
Assignees
Labels

Comments

@iKenndac
Copy link

By default, Xcode will create icon assets with many sizes, not all of which will be filled. For instance, CarPlay and "iTunes Marketing" are created in Xcode 9, which there's no need to fill with images for app icons in most cases.

If you don't fill sizes with images, the filename key will be missing entirely:

    {
      "size" : "40x40",
      "idiom" : "iphone",
      "scale" : "2x"
    }

When encountering such items, the app fails with the following error: 💥 The operation couldn’t be completed. (Unbox.UnboxError error 0.)

The only way to get around this is to manually strip these parts out using a text editor. Unfortunately, since these are valid as far as Xcode is concerned, they empty sections will be re-added if you open the file again with Xcode.

@alexisakers alexisakers self-assigned this Jun 23, 2017
alexisakers pushed a commit that referenced this issue Jun 23, 2017
- Configure app icon set parser to ignore invalid images
- Add empty images in icon sets in test asset catalog
@alexisakers
Copy link
Owner

Thanks for pointing out 😄 This bug has been fixed in v1.1

@iKenndac
Copy link
Author

Awesome! This is such a useful tool — thanks for making it! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants