Simplify OwnedFace; remove usage of Pin #4
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I understand it, the raison d'etre of
Pin
is to allow returning a type to the user which cannot be moved. Without a&mut
reference or direct ownership of the (unboxed) value this isn't possible anyway. See here.Further, we don't actually care about
SelfRefVecFace
being moved, we only care about the data (which is itself heap-allocated) being moved.I left
SelfRefVecFace
boxed only because theface
value is large enough that it probably shouldn't be copied around too much, but it's not required for safety.This PR simplifies things significantly without compromising safety or breaking the API.