Moment is not a dev dependency #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just ran into this myself on first attempt to use it. |
|
Yep, me too! However, I see @jmatsushita has made a fork out of his pull request #1, metalsmith-assets-copy, but the npm page links back here. I've filed an issue: contentascode/metalsmith-assets-copy#1 |
|
Actually, I discover the contentascode fork has other issues too... would you consider merging this @philgs? |
|
Merged and published to |
|
Thank you for merging! Unfortunately I am as it stands somewhat over-committed, and I doubt I could do a better job of maintenance. My use of this module is potentially quite transient. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
I couldn't run the plugin and realised that it was because it required moment as a devDependency!
Cheers,
Jun