Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why do you need this?
This PR adds the
--merge
flag to theplan
command, in order to add said flag to the generated script. This way, when executing the script, it is possible to merge the new kubeconfig with an existing one, making it easier to fully automate the creation of clusters in CI/CD pipelines without manual intervention--merge
flag tok3sup plan
command #438If you have no approval from a maintainer, close this PR and raise an issue.
Description
Added the flag to the command, with a check that conditionally adds the
--merge
flag to theinstall
command of the primary server. Indentation and blank lines remain the same as before.How Has This Been Tested?
Compiled the program and run it with and without the new flag. Here's the outputs:
./bin/k3sup plan hosts.json --local-path ./kubeconfig
:./bin/k3sup plan hosts.json --local-path ./kubeconfig --merge
:I haven't added unit tests, as there are none for the
plan
command.Types of changes
Checklist:
git commit -s