test: be explicit about which types are used in ts_project tests

This prevents @types packages added to the root package.json from inadvertently breaking tests on buildkite Windows CI where there is no sandboxing.
alexeagle · Apr 29, 2020 · 44b6a97 · 44b6a97
1 parent b4149d8
commit 44b6a97
Show file tree

Hide file tree

Showing 20 changed files with 51 additions and 14 deletions.
diff --git a/internal/linker/test/local/fit/tsconfig.json b/internal/linker/test/local/fit/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
-    "declaration": true
+    "declaration": true,
+    "types": []
   }
 }
diff --git a/internal/node/test/lib2/tsconfig.json b/internal/node/test/lib2/tsconfig.json
@@ -1 +1,5 @@
-{}
+{
+  "compilerOptions": {
+    "types": ["node"]
+  }
+}
diff --git a/internal/node/test/tsconfig.json b/internal/node/test/tsconfig.json
@@ -1,3 +1,6 @@
 {
+  "compilerOptions": {
+    "types": []
+  },
   "include": ["main.ts"]
 }
diff --git a/internal/pkg_npm/test/linking/fub/tsconfig.json b/internal/pkg_npm/test/linking/fub/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
-    "declaration": true
+    "declaration": true,
+    "types": []
   }
 }
diff --git a/internal/pkg_npm/test/linking/fuz/tsconfig.json b/internal/pkg_npm/test/linking/fuz/tsconfig.json
@@ -1,5 +1,6 @@
 {
   "compilerOptions": {
-    "declaration": true
+    "declaration": true,
+    "types": []
   }
 }
diff --git a/internal/pkg_npm/test/linking/tsconfig.json b/internal/pkg_npm/test/linking/tsconfig.json
@@ -1,6 +1,7 @@
 {
   "compilerOptions": {
-    "declaration": true
+    "declaration": true,
+    "types": []
   },
   "include": ["*.ts"]
 }
diff --git a/packages/rollup/test/integration/far/a/b/c/tsconfig.json b/packages/rollup/test/integration/far/a/b/c/tsconfig.json
@@ -4,6 +4,7 @@
     "strict": true,
     "target": "es2015",
     "module": "esnext",
-    "moduleResolution": "node"
+    "moduleResolution": "node",
+    "types": []
   }
 }
diff --git a/packages/rollup/test/integration/far/a/tsconfig.json b/packages/rollup/test/integration/far/a/tsconfig.json
@@ -4,7 +4,8 @@
     "strict": true,
     "target": "es2015",
     "module": "esnext",
-    "moduleResolution": "node"
+    "moduleResolution": "node",
+    "types": []
   },
   // For Windows, which is not sand-boxed, we need to limit
   // the typescript files included so the "@far/a" compilation

diff --git a/packages/rollup/test/integration/foo/tsconfig.json b/packages/rollup/test/integration/foo/tsconfig.json
@@ -4,6 +4,7 @@
     "strict": true,
     "target": "es2015",
     "module": "esnext",
-    "moduleResolution": "node"
+    "moduleResolution": "node",
+    "types": []
   }
 }
diff --git a/packages/rollup/test/integration/foo_a/tsconfig.json b/packages/rollup/test/integration/foo_a/tsconfig.json
@@ -4,6 +4,7 @@
     "strict": true,
     "target": "es2015",
     "module": "esnext",
-    "moduleResolution": "node"
+    "moduleResolution": "node",
+    "types": []
   }
 }
diff --git a/packages/rollup/test/integration/foo_aaa/tsconfig.json b/packages/rollup/test/integration/foo_aaa/tsconfig.json
@@ -4,6 +4,7 @@
     "strict": true,
     "target": "es2015",
     "module": "esnext",
-    "moduleResolution": "node"
+    "moduleResolution": "node",
+    "types": []
   }
 }
diff --git a/packages/typescript/src/checked_in_ts_project.bzl b/packages/typescript/src/checked_in_ts_project.bzl
@@ -31,6 +31,7 @@ def checked_in_ts_project(name, src, checked_in_js = None, **kwargs):
                 module = "commonjs",
                 removeComments = True,
                 declaration = True,
+                skipLibCheck = True,
             ),
             files = ["/".join([workspace_root, native.package_name(), src])],
         ).to_json()],

diff --git a/packages/typescript/test/ts_project/b/tsconfig-test.json b/packages/typescript/test/ts_project/b/tsconfig-test.json
@@ -1,5 +1,8 @@
 {
     "extends": "../tsconfig-base.json",
+    "compilerOptions": {
+        "types": ["jasmine", "node"]
+    },
     "references": [
         {"path": "./"}
     ],

diff --git a/packages/typescript/test/ts_project/empty_intermediate/tsconfig-a.json b/packages/typescript/test/ts_project/empty_intermediate/tsconfig-a.json
@@ -1,3 +1,6 @@
 {
-    "files": ["a.d.ts"]
+    "files": ["a.d.ts"],
+    "compilerOptions": {
+        "types": []
+    }
 }
diff --git a/packages/typescript/test/ts_project/empty_intermediate/tsconfig-b.json b/packages/typescript/test/ts_project/empty_intermediate/tsconfig-b.json
@@ -1,3 +1,6 @@
 {
-    "files": []
+    "files": [],
+    "compilerOptions": {
+        "types": []
+    }
 }
diff --git a/packages/typescript/test/ts_project/empty_intermediate/tsconfig-c.json b/packages/typescript/test/ts_project/empty_intermediate/tsconfig-c.json
@@ -11,5 +11,6 @@
             "../../../../../bazel-out/k8-dbg/bin/packages/typescript/test/ts_project/empty_intermediate",
             "../../../../../bazel-out/x64_windows-dbg/bin/packages/typescript/test/ts_project/empty_intermediate",
         ],
+        "types": []
     }
 }
diff --git a/packages/typescript/test/ts_project/rootdir/tsconfig.json b/packages/typescript/test/ts_project/rootdir/tsconfig.json
@@ -1 +1,5 @@
-{}
+{
+    "compilerOptions": {
+        "types": []
+    }
+}
diff --git a/packages/typescript/test/ts_project/simple/tsconfig.json b/packages/typescript/test/ts_project/simple/tsconfig.json
@@ -1 +1,5 @@
-{}
+{
+    "compilerOptions": {
+        "types": []
+    }
+}
diff --git a/packages/typescript/test/ts_project/tsconfig-base.json b/packages/typescript/test/ts_project/tsconfig-base.json
@@ -18,5 +18,6 @@
             "../../../../bazel-out/k8-dbg/bin/packages/typescript/test/ts_project",
             "../../../../bazel-out/x64_windows-dbg/bin/packages/typescript/test/ts_project",
         ],
+        "types": []
     }
 }
diff --git a/packages/typescript/test/ts_project/validation/tsconfig.json b/packages/typescript/test/ts_project/validation/tsconfig.json
@@ -5,5 +5,6 @@
         "declarationMap": true,
         "declaration": true,
         "sourceMap": true,
+        "types": []
     }
 }