Skip to content

Commit

Permalink
fix(create): disable sandbox on MacOS by default in new projects
Browse files Browse the repository at this point in the history
This trades-off performance for correctness, and might not be wise because
missing dependencies give non-hermetic behavior.
See bazelbuild/bazel#8230 (comment)

Also fix the default npm publish tag which cost me time in tonights release
  • Loading branch information
Alex Eagle committed Jul 24, 2020
1 parent 523dd96 commit 4196dce
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
7 changes: 7 additions & 0 deletions common.bazelrc
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,13 @@ run:debug --define=VERBOSE_LOGS=1 -- --node_options=--inspect-brk
# The following option will change the build output of certain rules such as terser and may not be desirable in all cases
build:debug --compilation_mode=dbg

# Allow bazelrc to have configs that enable automatically on certain platform
build --enable_platform_specific_config
# ... and use it to turn off sandboxing on Mac by default
# because it's slow: https://github.com/bazelbuild/bazel/issues/8230
# Syntax, see https://blog.bazel.build/2019/06/19/list-strategy.html
build:macos --spawn_strategy=worker,local

# Turn off legacy external runfiles
# This prevents accidentally depending on this feature, which Bazel will remove.
build --nolegacy_external_runfiles
Expand Down
2 changes: 1 addition & 1 deletion scripts/publish_release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ set -u -e -o pipefail
# $ npm login --registry https://wombat-dressing-room.appspot.com

readonly NPM_COMMAND=${1:-publish}
readonly NPM_TAG=${2:-next}
readonly NPM_TAG=${2:-latest}
readonly BAZEL_BIN=./node_modules/.bin/bazel

# Use a new output_base so we get a clean build
Expand Down

0 comments on commit 4196dce

Please sign in to comment.