Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error message when opening multi-stream as normal stream. #74

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve error message when opening multi-stream as normal stream. #74

wants to merge 1 commit into from

Conversation

Paul-E
Copy link

@Paul-E Paul-E commented Jan 31, 2021

Fixes #70

@alexcrichton
Copy link
Owner

Thanks for the PR, but I'm not sure that this is the best error message to return here. It seems sort of odd to mention on any possible corruption that a multi-stream might work insteaed. Would it be possible to only generate this sort of error when the error happens at a particular place or the input stream seems like it's a multi-xz stream?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve error output. "Corrupt XZ stream error" returned for files with multi-streams
2 participants
@Paul-E @alexcrichton