-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mtime is incorrectly read as 0 #349
Comments
konstin
added a commit
to astral-sh/uv
that referenced
this issue
Dec 13, 2023
Don't preserve mtime to work around alexcrichton/tar-rs#349 to fix #579.
This was referenced Dec 13, 2023
charliermarsh
pushed a commit
to astral-sh/uv
that referenced
this issue
Dec 13, 2023
Don't preserve mtime to work around alexcrichton/tar-rs#349 to fix #579.
konstin
added a commit
to astral-sh/uv
that referenced
this issue
Dec 13, 2023
Don't preserve mtime to work around alexcrichton/tar-rs#349 to fix #579.
tdejager
pushed a commit
to prefix-dev/rip
that referenced
this issue
Feb 15, 2024
These PR address 2 major issues and 1 small issue * zip file stamps issue alexcrichton/tar-rs#349 which we encountered when installing tomli-2.1.0 * changed from_filename signature so it can also produce Stree, which it's needed from pixi side * lowercase Root-Is-Purelib so we can install elsie library ( prefix-dev/pixi#771 (comment))
konstin
added a commit
to astral-sh/uv
that referenced
this issue
Feb 20, 2024
Don't preserve mtime to work around alexcrichton/tar-rs#349. Same as #634 except for the streaming unzip. Fixes #1748.
charliermarsh
pushed a commit
to astral-sh/uv
that referenced
this issue
Feb 20, 2024
## Summary Don't preserve mtime to work around alexcrichton/tar-rs#349. Same as #634 except for the streaming unzip. Fixes #1748. ## Test Plan Added the tomli source dist as test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For certain tar file, the
tar
command on ubuntu 23.10 andtarfile
in the python 3.11 standard library read the correct mtime, while tar-rs claims it's 0. Example: https://files.pythonhosted.org/packages/c0/3f/d7af728f075fb08564c5949a9c95e44352e23dee646869fa104a3b2060a3/tomli-2.0.1.tar.gztar-rs prints
0
:python prints
1644317623.2803335
:tar
sets the same timestamp:This creates a problem because the timstamps are by default inferred to unix time 1 (~1970), while python std's
zipfile
library does not support timestamps before 1980.The text was updated successfully, but these errors were encountered: