117616: Auto-fixed new linting rules

alexandrevryghem · Oct 11, 2024 · 1895066 · 1895066
1 parent 49853db
commit 1895066
Show file tree

Hide file tree

Showing 97 changed files with 299 additions and 333 deletions.
diff --git a/src/app/access-control/bulk-access/browse/bulk-access-browse.component.spec.ts b/src/app/access-control/bulk-access/browse/bulk-access-browse.component.spec.ts
@@ -9,7 +9,7 @@ import {
   NgbNavModule,
 } from '@ng-bootstrap/ng-bootstrap';
 import { TranslateModule } from '@ngx-translate/core';
-import { of } from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { buildPaginatedList } from '../../../core/data/paginated-list.model';
 import { PageInfo } from '../../../core/shared/page-info.model';
@@ -70,7 +70,7 @@ describe('BulkAccessBrowseComponent', () => {
   beforeEach(() => {
     fixture = TestBed.createComponent(BulkAccessBrowseComponent);
     component = fixture.componentInstance;
-    (component as any).selectableListService.getSelectableList.and.returnValue(of(testSelection));
+    (component as any).selectableListService.getSelectableList.and.returnValue(observableOf(testSelection));
     fixture.detectChanges();
   });
 

diff --git a/src/app/access-control/bulk-access/bulk-access.component.spec.ts b/src/app/access-control/bulk-access/bulk-access.component.spec.ts
@@ -5,7 +5,7 @@ import {
 } from '@angular/core/testing';
 import { RouterTestingModule } from '@angular/router/testing';
 import { TranslateModule } from '@ngx-translate/core';
-import { of } from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { Process } from '../../process-page/processes/process.model';
 import { BulkAccessControlService } from '../../shared/access-control-form-container/bulk-access-control.service';
@@ -113,7 +113,7 @@ describe('BulkAccessComponent', () => {
 
     beforeEach(() => {
 
-      (component as any).selectableListService.getSelectableList.and.returnValue(of(selectableListStateEmpty));
+      (component as any).selectableListService.getSelectableList.and.returnValue(observableOf(selectableListStateEmpty));
       fixture.detectChanges();
       component.settings = mockSettings;
     });
@@ -136,7 +136,7 @@ describe('BulkAccessComponent', () => {
 
     beforeEach(() => {
 
-      (component as any).selectableListService.getSelectableList.and.returnValue(of(selectableListState));
+      (component as any).selectableListService.getSelectableList.and.returnValue(observableOf(selectableListState));
       fixture.detectChanges();
       component.settings = mockSettings;
     });

diff --git a/src/app/access-control/group-registry/groups-registry.component.spec.ts b/src/app/access-control/group-registry/groups-registry.component.spec.ts
@@ -26,7 +26,6 @@ import { TranslateModule } from '@ngx-translate/core';
 import {
   Observable,
   of as observableOf,
-  of,
 } from 'rxjs';
 
 import { APP_DATA_SERVICES_MAP } from '../../../config/app-config.interface';
@@ -198,7 +197,7 @@ describe('GroupsRegistryComponent', () => {
     };
 
     configurationDataService = jasmine.createSpyObj('ConfigurationDataService', {
-      findByPropertyName: of({ payload: { value: 'test' } }),
+      findByPropertyName: observableOf({ payload: { value: 'test' } }),
     });
 
     authorizationService = jasmine.createSpyObj('authorizationService', ['isAuthorized']);

diff --git a/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.spec.ts b/src/app/admin/admin-ldn-services/ldn-service-form/ldn-service-form.component.spec.ts
@@ -30,10 +30,7 @@ import {
   TranslateService,
 } from '@ngx-translate/core';
 import { PaginationService } from 'ngx-pagination';
-import {
-  of as observableOf,
-  of,
-} from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { RouteService } from '../../../core/services/route.service';
 import { MockActivatedRoute } from '../../../shared/mocks/active-router.mock';
@@ -85,7 +82,7 @@ describe('LdnServiceFormEditComponent', () => {
 
 
   const translateServiceStub = {
-    get: () => of('translated-text'),
+    get: () => observableOf('translated-text'),
     instant: () => 'translated-text',
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
@@ -100,7 +97,7 @@ describe('LdnServiceFormEditComponent', () => {
     });
 
     ldnItemfiltersService = {
-      findAll: () => of(['item1', 'item2']),
+      findAll: () => observableOf(['item1', 'item2']),
     };
     cdRefStub = Object.assign({
       detectChanges: () => fixture.detectChanges(),

diff --git a/src/app/admin/admin-ldn-services/ldn-service-serviceMock/ldnServicesRD$-mock.ts b/src/app/admin/admin-ldn-services/ldn-service-serviceMock/ldnServicesRD$-mock.ts
@@ -1,6 +1,6 @@
 import {
   Observable,
-  of,
+  of as observableOf,
 } from 'rxjs';
 
 import { PaginatedList } from '../../../core/data/paginated-list.model';
@@ -112,4 +112,4 @@ export const mockLdnServices: LdnService[] = [{
   },
 },
 ];
-export const mockLdnServicesRD$: Observable<RemoteData<PaginatedList<LdnService>>> = of((mockLdnServices as unknown) as RemoteData<PaginatedList<LdnService>>);
+export const mockLdnServicesRD$: Observable<RemoteData<PaginatedList<LdnService>>> = observableOf((mockLdnServices as unknown) as RemoteData<PaginatedList<LdnService>>);
diff --git a/src/app/admin/admin-ldn-services/ldn-services-data/ldn-itemfilter-data.service.spec.ts b/src/app/admin/admin-ldn-services/ldn-services-data/ldn-itemfilter-data.service.spec.ts
@@ -2,7 +2,7 @@ import {
   cold,
   getTestScheduler,
 } from 'jasmine-marbles';
-import { of } from 'rxjs';
+import { of as observableOf } from 'rxjs';
 import { TestScheduler } from 'rxjs/testing';
 
 import { RemoteDataBuildService } from '../../../core/cache/builders/remote-data-build.service';
@@ -59,12 +59,12 @@ describe('LdnItemfiltersService test', () => {
       generateRequestId: requestUUID,
       send: true,
       removeByHrefSubstring: {},
-      getByHref: of(responseCacheEntry),
-      getByUUID: of(responseCacheEntry),
+      getByHref: observableOf(responseCacheEntry),
+      getByUUID: observableOf(responseCacheEntry),
     });
 
     halService = jasmine.createSpyObj('halService', {
-      getEndpoint: of(endpointURL),
+      getEndpoint: observableOf(endpointURL),
     });
 
     rdbService = jasmine.createSpyObj('rdbService', {

diff --git a/.../admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.spec.ts b/.../admin/admin-ldn-services/ldn-services-directory/ldn-services-directory.component.spec.ts
@@ -15,7 +15,7 @@ import {
   TranslateModule,
   TranslateService,
 } from '@ngx-translate/core';
-import { of } from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { PaginatedList } from '../../../core/data/paginated-list.model';
 import { RemoteData } from '../../../core/data/remote-data';
@@ -41,7 +41,7 @@ describe('LdnServicesOverviewComponent', () => {
   let modalService: NgbModal;
 
   const translateServiceStub = {
-    get: () => of('translated-text'),
+    get: () => observableOf('translated-text'),
     onLangChange: new EventEmitter(),
     onTranslationChange: new EventEmitter(),
     onDefaultLangChange: new EventEmitter(),
@@ -96,7 +96,7 @@ describe('LdnServicesOverviewComponent', () => {
     modalService = TestBed.inject(NgbModal);
     component.modalRef = jasmine.createSpyObj({ close: null });
     component.isProcessingSub = jasmine.createSpyObj({ unsubscribe: null });
-    component.ldnServicesRD$ = of({} as RemoteData<PaginatedList<LdnService>>);
+    component.ldnServicesRD$ = observableOf({} as RemoteData<PaginatedList<LdnService>>);
     fixture.detectChanges();
   });
 
@@ -162,7 +162,7 @@ describe('LdnServicesOverviewComponent', () => {
       const serviceId = '123';
       const mockRemoteData = { /* just an empty object to retrieve as as RemoteData<PaginatedList<LdnService>>  */};
       spyOn(component, 'setLdnServices').and.callThrough();
-      const deleteSpy = ldnServicesService.delete.and.returnValue(of(mockRemoteData as RemoteData<PaginatedList<LdnService>>));
+      const deleteSpy = ldnServicesService.delete.and.returnValue(observableOf(mockRemoteData as RemoteData<PaginatedList<LdnService>>));
       component.selectedServiceId = serviceId;
       component.deleteSelected(serviceId, ldnServicesService);
       tick();

diff --git a/...-notify-dashboard/admin-notify-search-result/admin-notify-search-result.component.spec.ts b/...-notify-dashboard/admin-notify-search-result/admin-notify-search-result.component.spec.ts
@@ -7,10 +7,7 @@ import {
 import { RouterModule } from '@angular/router';
 import { NgbModal } from '@ng-bootstrap/ng-bootstrap';
 import { TranslateModule } from '@ngx-translate/core';
-import {
-  of as observableOf,
-  of,
-} from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { SearchConfigurationService } from '../../../core/shared/search/search-configuration.service';
 import { SEARCH_CONFIG_SERVICE } from '../../../my-dspace-page/my-dspace-configuration.service';
@@ -87,11 +84,11 @@ describe('AdminNotifySearchResultComponent', () => {
 
   beforeEach(async () => {
     adminNotifyMessageService = jasmine.createSpyObj('adminNotifyMessageService', {
-      getDetailedMessages: of(mockAdminNotifyMessages),
-      reprocessMessage: of(mockAdminNotifyMessages),
+      getDetailedMessages: observableOf(mockAdminNotifyMessages),
+      reprocessMessage: observableOf(mockAdminNotifyMessages),
     });
     searchConfigService = jasmine.createSpyObj('searchConfigService', {
-      getCurrentConfiguration: of('NOTIFY.outgoing'),
+      getCurrentConfiguration: observableOf('NOTIFY.outgoing'),
     });
 
     await TestBed.configureTestingModule({
@@ -150,7 +147,7 @@ describe('AdminNotifySearchResultComponent', () => {
   });
 
   it('should unsubscribe on destroy', () => {
-    (component as any).subs = [of(null).subscribe()];
+    (component as any).subs = [observableOf(null).subscribe()];
 
     spyOn((component as any).subs[0], 'unsubscribe');
     component.ngOnDestroy();

diff --git a/src/app/admin/admin-notify-dashboard/services/admin-notify-messages.service.spec.ts b/src/app/admin/admin-notify-dashboard/services/admin-notify-messages.service.spec.ts
@@ -2,7 +2,7 @@ import { deepClone } from 'fast-json-patch';
 import { cold } from 'jasmine-marbles';
 import {
   BehaviorSubject,
-  of,
+  of as observableOf,
 } from 'rxjs';
 import { take } from 'rxjs/operators';
 
@@ -67,12 +67,12 @@ describe('AdminNotifyMessagesService test', () => {
       generateRequestId: requestUUID,
       send: true,
       removeByHrefSubstring: {},
-      getByHref: of(responseCacheEntry),
-      getByUUID: of(responseCacheEntry),
+      getByHref: observableOf(responseCacheEntry),
+      getByUUID: observableOf(responseCacheEntry),
     });
 
     halService = jasmine.createSpyObj('halService', {
-      getEndpoint: of(endpointURL),
+      getEndpoint: observableOf(endpointURL),
     });
 
     rdbService = jasmine.createSpyObj('rdbService', {

diff --git a/src/app/admin/admin-notify-dashboard/services/admin-notify-messages.service.ts b/src/app/admin/admin-notify-dashboard/services/admin-notify-messages.service.ts
@@ -3,7 +3,7 @@ import {
   BehaviorSubject,
   from,
   Observable,
-  of,
+  of as observableOf,
   scan,
 } from 'rxjs';
 import {
@@ -64,13 +64,13 @@ export class AdminNotifyMessagesService extends IdentifiableDataService<AdminNot
         message.target || message.origin ? this.ldnServicesService.findById((message.target || message.origin).toString()).pipe(
           getAllSucceededRemoteDataPayload(),
           map(detail => ({ ...message, ldnService: detail.name })),
-        ) : of(message),
+        ) : observableOf(message),
       ),
       mergeMap(message =>
         message.object || message.context  ? this.itemDataService.findById(message.object || message.context).pipe(
           getAllSucceededRemoteDataPayload(),
           map(detail => ({ ...message, relatedItem: detail.name })),
-        ) : of(message),
+        ) : observableOf(message),
       ),
       scan((acc: any, value: any) => [...acc, value], []),
     );

diff --git a/...arch-results/actions/workflow-item/workflow-item-admin-workflow-actions.component.spec.ts b/...arch-results/actions/workflow-item/workflow-item-admin-workflow-actions.component.spec.ts
@@ -7,7 +7,7 @@ import {
 import { By } from '@angular/platform-browser';
 import { RouterTestingModule } from '@angular/router/testing';
 import { TranslateModule } from '@ngx-translate/core';
-import { of } from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { RemoteData } from '../../../../../core/data/remote-data';
 import { RequestEntryState } from '../../../../../core/data/request-entry-state.model';
@@ -33,7 +33,7 @@ describe('WorkflowItemAdminWorkflowActionsComponent', () => {
     id = '780b2588-bda5-4112-a1cd-0b15000a5339';
     wfi = new WorkflowItem();
     wfi.id = id;
-    wfi.item = of(rd);
+    wfi.item = observableOf(rd);
   }
 
   beforeEach(waitForAsync(() => {

diff --git a/...-item/supervision-order-group-selector/supervision-order-group-selector.component.spec.ts b/...-item/supervision-order-group-selector/supervision-order-group-selector.component.spec.ts
@@ -12,7 +12,7 @@ import {
   NgbPaginationModule,
 } from '@ng-bootstrap/ng-bootstrap';
 import { TranslateModule } from '@ngx-translate/core';
-import { of } from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { Group } from '../../../../../../core/eperson/models/group.model';
 import { SupervisionOrder } from '../../../../../../core/supervision-order/models/supervision-order.model';
@@ -29,7 +29,7 @@ describe('SupervisionOrderGroupSelectorComponent', () => {
   const modalStub = jasmine.createSpyObj('modalStub', ['close']);
 
   const supervisionOrderDataService: any = jasmine.createSpyObj('supervisionOrderDataService', {
-    create: of(new SupervisionOrder()),
+    create: observableOf(new SupervisionOrder()),
   });
 
   const selectedOrderType = 'NONE';

diff --git a/...ch-results/actions/workspace-item/workspace-item-admin-workflow-actions.component.spec.ts b/...ch-results/actions/workspace-item/workspace-item-admin-workflow-actions.component.spec.ts
@@ -8,7 +8,7 @@ import { By } from '@angular/platform-browser';
 import { RouterTestingModule } from '@angular/router/testing';
 import { NgbModalModule } from '@ng-bootstrap/ng-bootstrap';
 import { TranslateModule } from '@ngx-translate/core';
-import { of } from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { DSONameService } from '../../../../../core/breadcrumbs/dso-name.service';
 import { RemoteData } from '../../../../../core/data/remote-data';
@@ -46,7 +46,7 @@ describe('WorkspaceItemAdminWorkflowActionsComponent', () => {
     id = '780b2588-bda5-4112-a1cd-0b15000a5339';
     wsi = new WorkspaceItem();
     wsi.id = id;
-    wsi.item = of(rd);
+    wsi.item = observableOf(rd);
   }
 
   beforeEach(waitForAsync(() => {
@@ -96,14 +96,14 @@ describe('WorkspaceItemAdminWorkflowActionsComponent', () => {
     beforeEach(() => {
       spyOn(component.delete, 'emit');
       spyOn((component as any).modalService, 'open').and.returnValue({
-        componentInstance: { response: of(true) },
+        componentInstance: { response: observableOf(true) },
       });
     });
 
     describe('when delete succeeded', () => {
 
       beforeEach(() => {
-        supervisionOrderDataService.delete.and.returnValue(of(true));
+        supervisionOrderDataService.delete.and.returnValue(observableOf(true));
       });
 
       it('should notify success', () => {
@@ -118,7 +118,7 @@ describe('WorkspaceItemAdminWorkflowActionsComponent', () => {
     describe('when delete failed', () => {
 
       beforeEach(() => {
-        supervisionOrderDataService.delete.and.returnValue(of(false));
+        supervisionOrderDataService.delete.and.returnValue(observableOf(false));
       });
 
       it('should notify success', () => {
@@ -137,7 +137,7 @@ describe('WorkspaceItemAdminWorkflowActionsComponent', () => {
     beforeEach(() => {
       spyOn(component.create, 'emit');
       spyOn((component as any).modalService, 'open').and.returnValue({
-        componentInstance: { create: of(true) },
+        componentInstance: { create: observableOf(true) },
       });
     });
 

diff --git a/...dit-collection-page/collection-access-control/collection-access-control.component.spec.ts b/...dit-collection-page/collection-access-control/collection-access-control.component.spec.ts
@@ -3,10 +3,7 @@ import {
   TestBed,
 } from '@angular/core/testing';
 import { ActivatedRoute } from '@angular/router';
-import {
-  of as observableOf,
-  of,
-} from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { Community } from '../../../core/shared/community.model';
 import { AccessControlFormContainerComponent } from '../../../shared/access-control-form-container/access-control-form-container.component';
@@ -35,7 +32,7 @@ describe('CollectionAccessControlComponent', () => {
   const routeStub = {
     parent: {
       parent: {
-        data: of({
+        data: observableOf({
           dso: createSuccessfulRemoteDataObject(testCommunity),
         }),
       },

diff --git a/...e/edit-community-page/community-access-control/community-access-control.component.spec.ts b/...e/edit-community-page/community-access-control/community-access-control.component.spec.ts
@@ -3,10 +3,7 @@ import {
   TestBed,
 } from '@angular/core/testing';
 import { ActivatedRoute } from '@angular/router';
-import {
-  of as observableOf,
-  of,
-} from 'rxjs';
+import { of as observableOf } from 'rxjs';
 
 import { Community } from '../../../core/shared/community.model';
 import { AccessControlFormContainerComponent } from '../../../shared/access-control-form-container/access-control-form-container.component';
@@ -36,7 +33,7 @@ describe('CommunityAccessControlComponent', () => {
   const routeStub = {
     parent: {
       parent: {
-        data: of({
+        data: observableOf({
           dso: createSuccessfulRemoteDataObject(testCommunity),
         }),
       },