Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix panic on sse-server shutdown #36

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

hotafrika
Copy link

This is the fix for the "panic on sse-server shutdown when there is at least one active connection" issue.
It does the following:

  1. after calling the Shutdown() function it doesn't allow new sse-connections to be established
  2. it avoids sending to already closed removeClient channel

@insano10
Copy link

I've tested this forked version in an application utilising go-sse and can confirm it fixes the panic on shutdown

Copy link

@insano10 insano10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants