Cleanup code using AS code inspection

alexandr7035 · Jul 19, 2022 · 9918c45 · 9918c45
1 parent c464edc
commit 9918c45
Show file tree

Hide file tree

Showing 9 changed files with 6 additions and 83 deletions.
diff --git a/...by/alexandr7035/affinidi_id/presentation/credential_details/CredentialViewPagerAdapter.kt b/...by/alexandr7035/affinidi_id/presentation/credential_details/CredentialViewPagerAdapter.kt
@@ -8,7 +8,7 @@ import java.lang.IllegalStateException
 
 class CredentialViewPagerAdapter(
     private val tabsCount: Int,
-    private val parentFragment: Fragment
+    parentFragment: Fragment
 ): FragmentStateAdapter(parentFragment) {
     override fun getItemCount(): Int {
         return tabsCount

diff --git a/...lexandr7035/affinidi_id/presentation/credential_details/LoadCredentialDetailsViewModel.kt b/...lexandr7035/affinidi_id/presentation/credential_details/LoadCredentialDetailsViewModel.kt
@@ -4,7 +4,6 @@ import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
 import androidx.lifecycle.viewModelScope
-import by.alexandr7035.affinidi_id.core.extensions.debug
 import by.alexandr7035.affinidi_id.domain.model.credentials.get_from_qr_code.ObtainVcFromQrCodeReqModel
 import by.alexandr7035.affinidi_id.domain.model.credentials.get_from_qr_code.ObtainVcFromQrCodeResModel
 import by.alexandr7035.affinidi_id.domain.model.credentials.stored_credentials.GetCredentialByIdReqModel
@@ -17,7 +16,6 @@ import dagger.hilt.android.lifecycle.HiltViewModel
 import kotlinx.coroutines.Dispatchers
 import kotlinx.coroutines.launch
 import kotlinx.coroutines.withContext
-import timber.log.Timber
 import javax.inject.Inject
 
 @HiltViewModel

diff --git a/...r7035/affinidi_id/presentation/credential_details/model/CredentialToDetailsModelMapper.kt b/...r7035/affinidi_id/presentation/credential_details/model/CredentialToDetailsModelMapper.kt
@@ -1,7 +1,6 @@
 package by.alexandr7035.affinidi_id.presentation.credential_details.model
 
 import by.alexandr7035.affinidi_id.domain.model.credentials.stored_credentials.Credential
-import by.alexandr7035.affinidi_id.presentation.credential_details.model.CredentialDetailsUi
 
 interface CredentialToDetailsModelMapper {
     fun map(credential: Credential): CredentialDetailsUi.Success

diff --git a/...java/by/alexandr7035/affinidi_id/presentation/credentials_list/CredentialsListFragment.kt b/...java/by/alexandr7035/affinidi_id/presentation/credentials_list/CredentialsListFragment.kt
@@ -1,6 +1,5 @@
 package by.alexandr7035.affinidi_id.presentation.credentials_list
 
-import android.net.wifi.hotspot2.pps.Credential
 import android.os.Bundle
 import android.view.LayoutInflater
 import android.view.View
@@ -22,7 +21,6 @@ import by.kirich1409.viewbindingdelegate.viewBinding
 import com.google.android.material.tabs.TabLayout
 import dagger.hilt.android.AndroidEntryPoint
 import timber.log.Timber
-import java.lang.RuntimeException
 
 
 @AndroidEntryPoint

diff --git a/...va/by/alexandr7035/affinidi_id/presentation/credentials_list/filters/CredentialFilters.kt b/...va/by/alexandr7035/affinidi_id/presentation/credentials_list/filters/CredentialFilters.kt
@@ -1,6 +1,6 @@
 package by.alexandr7035.affinidi_id.presentation.credentials_list.filters
 
-sealed class CredentialFilters() {
+sealed class CredentialFilters {
     object All: CredentialFilters()
 
     object Active: CredentialFilters()

diff --git a/...y/alexandr7035/affinidi_id/presentation/scan_credential_qr/VerifyCredentialQrViewModel.kt b/...y/alexandr7035/affinidi_id/presentation/scan_credential_qr/VerifyCredentialQrViewModel.kt
diff --git a/app/src/main/res/layout/view_credential_item_detailed.xml b/app/src/main/res/layout/view_credential_item_detailed.xml
@@ -87,7 +87,7 @@
 
         <TextView
             android:id="@+id/issuedByLabel"
-            android:text="Issued by"
+            android:text="@string/issued_by"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
             app:layout_constraintTop_toTopOf="parent"
@@ -97,15 +97,15 @@
             android:id="@+id/issuer"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:text="did:elem:123..3434"
+            tools:text="did:elem:123..3434"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintTop_toTopOf="parent"/>
 
         <TextView
             android:id="@+id/statusValue"
             android:layout_width="wrap_content"
             android:layout_height="wrap_content"
-            android:text="did:elem:123..3434"
+            tools:text="did:elem:123..3434"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintTop_toTopOf="@id/statusLabel"
             app:layout_constraintBottom_toBottomOf="@id/statusLabel"/>

diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml
@@ -109,5 +109,6 @@
 
     <string name="proof">Proof</string>
     <string name="claims">Claims</string>
+    <string name="issued_by">Issued by</string>
 
 </resources>
diff --git a/data/src/main/java/by/alexandr7035/data/repository/LoginRepositoryImpl.kt b/data/src/main/java/by/alexandr7035/data/repository/LoginRepositoryImpl.kt
@@ -5,7 +5,6 @@ import by.alexandr7035.affinidi_id.domain.model.login.LogOutModel
 import by.alexandr7035.affinidi_id.domain.model.login.SignInModel
 import by.alexandr7035.affinidi_id.domain.repository.LoginRepository
 import by.alexandr7035.data.datasource.cache.credentials.CredentialsCacheDataSource
-import by.alexandr7035.data.datasource.cache.credentials.CredentialsDAO
 import by.alexandr7035.data.datasource.cache.secrets.SecretsStorage
 import by.alexandr7035.data.datasource.cloud.ApiCallHelper
 import by.alexandr7035.data.datasource.cloud.ApiCallWrapper