Allow for non-global usage #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure why this fails in phantom it works on my machine 😕. Any ideas? |
|
Sounds interesting. I'm currently on holiday and will look at it in one week. |
|
I see your point. I think that the global registration for phrasers is not a good idea, because as you said already, usage of phrasers in a lib will infer with the usage of phrasers in an app using that lib. I have to think about more whether your solution is the right way to move forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the concept of a
dictionarywhich is a named library of phrasers. This allows one to create their own phrasers without having them be overwritten by other users of the library