Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give some->/some->> similar treatment than that of ->/->> #109

Closed
vemv opened this issue Sep 29, 2023 · 2 comments · Fixed by #110
Closed

Give some->/some->> similar treatment than that of ->/->> #109

vemv opened this issue Sep 29, 2023 · 2 comments · Fixed by #110

Comments

@vemv
Copy link
Contributor

vemv commented Sep 29, 2023

As some context (and good news), -> has kept working for me, in this case honoring ^String metadata specified in a less obvious place:

image

Now, I realised this doesn't work for some-> and some->>.

Should be a pretty easy PR (if you don't wish to beat me to it).

Cheers - V

@alexander-yakushev
Copy link
Owner

Go ahead, would gladly merge it

vemv added a commit to reducecombine/compliment that referenced this issue Sep 29, 2023
vemv added a commit to reducecombine/compliment that referenced this issue Sep 29, 2023
alexander-yakushev pushed a commit that referenced this issue Sep 29, 2023
@vemv
Copy link
Contributor Author

vemv commented Oct 5, 2023

I've tested the snapshot out for a few days and it works as intended - a release would be appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants