Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make signature verifier more resilient to HTTP retrieval errors #230

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Make signature verifier more resilient to HTTP retrieval errors #230

merged 1 commit into from
Nov 18, 2019

Conversation

breedloj
Copy link
Contributor

Description

Certificate retrieval logic will now retry up to 5 times in cases where:

  • A non-200 response code is received
  • An IOException occurs when establishing the HTTP connection

Additionally, the cert will be checked for validity (not expired) before re-using it from the cache, avoiding a possible edge case issue if a long-running instance overlapped two certificates.

Testing

Tested with a servlet enabled sample skill in various conditions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

  • I confirm that this pull request can be released under the Apache 2 license

@breedloj breedloj requested a review from nikhilym November 18, 2019 19:52
Copy link
Contributor

@nikhilym nikhilym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

@breedloj breedloj merged commit 85fd0f0 into alexa:2.0.x Nov 18, 2019
@breedloj breedloj changed the title Make signature verifier more resiliant to HTTP retrieval errors Make signature verifier more resilient to HTTP retrieval errors Nov 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants