Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PlayBehavior to be set on ResponseBuilder speech and reprompt h… #176

Merged
merged 1 commit into from
Feb 15, 2019
Merged

Conversation

breedloj
Copy link
Contributor

Description

Adds overloaded methods for response builder withSpeech and withReprompt to allow PlayBehavior to be set.

Motivation and Context

PlayBehavior attribute on Alexa Response provides a way to interrupt Alexa speech, which is useful during some skill development like game skills. Since Response Builder is the SDK's way of generating the response, we need to provide a way to add this attribute on the speak and ask commands of the builder, for skill developers to use.

Testing

New unit tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@nikhilym nikhilym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@breedloj breedloj merged commit cdb0d57 into alexa:2.0.x Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants