Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Card in ResponseBuilder #155

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Add Card in ResponseBuilder #155

merged 1 commit into from
Nov 8, 2018

Conversation

Chris-Liao
Copy link
Contributor

Description

Add Card in ResponseBuilder so that pre-constructed Card object and its children classes can be passed to ResponseBuilder.

Motivation and Context

Customer raised a request.

Testing

  1. add card on response builder
  2. mvn package sdk core, get sdk-core jar
  3. update sdk dependency on newer sdk-core jar
  4. package sdk with all its dependencies, get sdk jar
  5. update sample skill dependency on newer sdk jar
  6. package sample skill with all its dependencies, get skill jar
  7. upload skill jar to lambda
  8. verify response

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have read the README document
  • I have added tests to cover my changes
  • All new and existing tests passed

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Chris-Liao Chris-Liao requested a review from breedloj November 8, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants