Js/test coverage #60
Merged
Js/test coverage #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds cards test
|
@radishmouse ^^ |
| return expect(subject).to.eventually.become({ | ||
| ssml: "<speak>" + expectedReprompt + "</speak>", | ||
| type: "SSML" | ||
| }); |
There was a problem hiding this comment.
this result also seemed strange - i saw in the code path logic for combining reprompts but i didn't observe that behavior.
|
Added Travis CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request, i make a first pass at adding test coverage to alexa-app.
I also have add travis and code coverage integration so that we've got a way to check new pull requests pass the test suite.
@matt-kruse : For the travis integration to be active on the project, please enable the travis integration on the github repository - I currently don't have access to enable that in settings.
https://www.evernote.com/l/ATn8zc-KNIFOsLbcH5p9m-70PqIwgHUTIp4B/image.png
Also, the code coverage report integration is via coveralls.
Here is the output: https://coveralls.io/builds/6062172