Issue #359 .reprompt() not concatenating #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/alexa-js/alexa-app/blob/master/index.js#L51 Example: the following will speak "1 2" as output. response.reprompt("1").reprompt("2")
|
Hi @andrewjhunt, can you please update the CHANGELOG and also add a note about the concatenation of |
kobim
suggested changes
Aug 21, 2018
CHANGELOG.md
Outdated
| @@ -5,7 +5,7 @@ | |||
| * [#344](https://github.com/alexa-js/alexa-app/pull/344): Add coveralls as a check for pull requests - [@kobim](https://github.com/kobim). | |||
| * [#352](https://github.com/alexa-js/alexa-app/pull/352): Allow utterance expansion in custom slot type synonyms - [@daanzu](https://github.com/daanzu). | |||
| * [#361](https://github.com/alexa-js/alexa-app/pull/361): Fix object reference for dialogState in in doc - [@Sephtenen](https://github.com/Sephtenen). | |||
| * Your contribution here. | |||
| * [#364](https://github.com/alexa-js/alexa-app/pull/364): Fix reprompt() to concatenate multiple SSML prompts - [@andrewjhunt](https://github.com/andrewjhunt). | |||
There was a problem hiding this comment.
Please re-add the deleted "* Your contribution here." beneath.
|
added reprompt() multiple use doc to README.md and index.d.ts |
kobim
suggested changes
Aug 23, 2018
As requested by kobim
kobim
approved these changes
Sep 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #359
https://github.com/alexa-js/alexa-app/blob/master/index.js#L51
Example: the following will speak "1 2" as output.
response.reprompt("1").reprompt("2")
Existing unit tests are updated and pass.
NOTE: the doc is not explicit on the expected behavior of multiple reprompts for the same response. I expected that multiple reprompt() would also concatenate as say(). The existing unit tests didn't reflect this but it's not clear that was intentional. Plus the code appeared to reference a non-defined variable.