Add coveralls as a check for pull requests #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*** 100% coverage ***
kobim
changed the title
kobim
changed the title
|
👍 |
daanzu
pushed a commit
to daanzu/alexa-app
that referenced
this pull request
May 19, 2018
…irement Add coveralls as a check for pull requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #330, I added coveralls as a status check on pull requests, so we will be able to understand if coverage increased/decreased before we merge (and act accordingly).
In the process, I added/fixed tests to make sure all the branches of the code will get called - reached to 100% coverage across all parameters.