Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated alexa-verifier-middleware to v1.0.0 #301

Merged
merged 3 commits into from
Nov 22, 2017
Merged

updated alexa-verifier-middleware to v1.0.0 #301

merged 3 commits into from
Nov 22, 2017

Conversation

tejashah88
Copy link
Member

There has been many underlying changes to alexa-verifier, particularly with improvements to the stability and security of the module. Recently it's reached v1.0.0, so I have thus updated the middleware module to reflect the recent changes.

@tejashah88
Copy link
Member Author

Seems like there's a problem with node v9.2.0 and typescript? @lazerwalker

image

@lazerwalker
Copy link
Collaborator

Just pushed a fix to this branch that should fix CI. TypeScript frustratingly changed things so that a formerly-optional config key is now mandatory, so adding it in should fix things.

Otherwise, this looks 👍 to me!

@lazerwalker
Copy link
Collaborator

Fixed up the various other tslint issues that arose as a result of bumping versions.

The only slightly sketchy one is that we seem to be running into a dtslint/compiler bug that means it was incorrectly yelling at us for what should have been a valid TS definition. Had to manually add in a linter config to ignore that rule while I open an issue with the actual dtslint repo.

Will leave merging to you, but I'm satisfied? Your stuff looks good, and CI's green.

This involves adding a tslint.json file that manually excludes a rule which appears to have a bug in it.
@tejashah88
Copy link
Member Author

Thanks for helping out with the typescript shenanigans!

@tejashah88 tejashah88 deleted the update-verifier-middleware branch November 22, 2017 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants