Always enfore strict header checking [broken] #174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This forces all kinds of upgrades on people, like bluebird, alexa-utterances, etc., while the library is perfectly compatible with older verisons. I think you should revert package.json and only do the upgrade that is required by the interface change. |
|
Also build seems to have broken because of the danger upgrade. |
|
Still broken, revert package.json and do only the update of the minimum version of alexa-verifier-middleware. |
dblock
reviewed
Feb 13, 2017
| @@ -183,15 +183,6 @@ describe("Alexa", function() { | |||
| }); | |||
| }); | |||
|
|
|||
| it("requires a cert header", function() { | |||
There was a problem hiding this comment.
What's the reason for removing this test?
This will be removed in the next major version
Also updated logging of old functionality to include stack trace
tejashah88
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated
alexa-verifier-middlewareto0.2.1from0.1.9, which removes thestrictHeaderCheckoption. Either the verification should be completely on, or completely off.