Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatibility with Node.js v0.12 - v7 #139

Merged
merged 4 commits into from
Jan 31, 2017
Merged

Compatibility with Node.js v0.12 - v7 #139

merged 4 commits into from
Jan 31, 2017

Conversation

tejashah88
Copy link
Member

@tejashah88 tejashah88 commented Jan 31, 2017 •
edited
Loading

  • Compatibility with Node.js v0.12 - v7

@tejashah88
Mocha Testing changes
9432dbb 
* Added more node versions to run mocha tests on Travis-CI
* Changed arrow functions to normal functions (see https://mochajs.org/#arrow-functions for more info)
@coveralls
Copy link

coveralls commented Jan 31, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 98.344% when pulling 9432dbb on tejashah88:master into 1741687 on alexa-js:master.

@coveralls
Copy link

coveralls commented Jan 31, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 98.344% when pulling f0b2eb6 on tejashah88:master into 1741687 on alexa-js:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.344% when pulling f0b2eb6 on tejashah88:master into 1741687 on alexa-js:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.344% when pulling f0b2eb6 on tejashah88:master into 1741687 on alexa-js:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 98.344% when pulling f0b2eb6 on tejashah88:master into 1741687 on alexa-js:master.

@coveralls
Copy link

coveralls commented Jan 31, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 98.344% when pulling dbe4f53 on tejashah88:master into 1741687 on alexa-js:master.

@coveralls
Copy link

coveralls commented Jan 31, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 98.344% when pulling 9d6b5b2 on tejashah88:master into 1741687 on alexa-js:master.

@dblock
Copy link
Collaborator

dblock commented Jan 31, 2017

So the change is really about running tests on multiple versions of node, right? How about rewriting changelog to say "Compatibility with Node.js 0.12-7" or something like that? Fat arrows in tests is really not worth calling out :) I'll merge, if you feel like it you can amend changelog in a future PR.

@dblock dblock merged commit 3e70730 into alexa-js:master Jan 31, 2017
@tejashah88 tejashah88 changed the title Mocha Testing changes Compatibility with Node.js v0.12 - v7 Jan 31, 2017
@tejashah88 tejashah88 mentioned this pull request Jan 31, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tejashah88 @coveralls @dblock @mreinstein