-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test hangs in verifier #152
Comments
@mreinstein you might be able to explain this one, I'm probably missing something obvious |
…in Express integration.
So ... we need a body parser after the middleware. Does this mean #155? |
the alexa-verifier-middleware already effectively acts like a JSON body parser. see: https://github.com/alexa-js/alexa-verifier-middleware/blob/master/index.js#L31 I think the logic should be:
the |
…in Express integration.
Ok, cool, updated. I am also not moving body-parser into dependencies just like we do with express. I assume this is correct? |
if the code is using |
…in Express integration.
…in Express integration.
We only use it in the express scenario, but you're right. |
Fix #152: mount a JSON body-parser after verifier middleware in Express integration.
This test hangs for no reason: https://github.com/dblock/alexa-app/blob/test-hangs/test/test_alexa_verifier_middleware_hangs.js, the middleware never fires
on('end', function() { })
, not sure what's going on.The text was updated successfully, but these errors were encountered: