Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #96

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #96

wants to merge 1 commit into from

Conversation

Reagankm
Copy link

Requirements for Contributing a Performance Improvement

  • Fill out the template below. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • The pull request must only affect performance of existing functionality. To contribute other changes, you must use a different template.
  • After you create the pull request, all status checks must be pass before a maintainer reviews your contribution.

Description of the Change

(This was the closest template I could find.)

Updated the README to include two requirements that are needed for the package to work.

I attempted to install and use this package but got an error about not having gesture-handler, which went away after I installed it, but then I got the error "Unable to resolve module expo-modules-core".

Quantitative Performance Benefits

Gives users info about additional installation requirements

Possible Drawbacks

None

Verification Process

N/A

Applicable Issues

NA

Release Notes

Added additional requirements to installation instructions in README.

I got an error about not having gesture-handler, which went away after I installed it, but then I got the error "Unable to resolve module expo-modules-core".  If these are requirements, it'd be useful to mention that earlier.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant