Highlight Self and defer appropriately #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds special case `#eq?` clauses into the highlight queries for special
cases where we have keywords or builtins that aren't in the grammar.
Specifically:
* With `Self`, this is parsed as a boring type identifier, but should be
highlighted as a builtin variable.
* With `defer { }`, this is parsed as a function, but the behavior is
unique enough that it is reasonable to present it as a keyword.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds special case
#eq?clauses into the highlight queries for special cases where we have keywords or builtins that aren't in the grammar.Specifically:
Self, this is parsed as a boring type identifier, but should behighlighted as a builtin variable.
defer { }, this is parsed as a function, but the behavior isunique enough that it is reasonable to present it as a keyword.
With this and other recent fixes, all of the issues identified in #351 have been fixed.