Fix parse ambiguity with types in navigation expressions #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, let’s come back to this then lol |
alex-pinkus
added a commit
that referenced
this pull request
Mar 3, 2024
In #353, adding `_parenthesized_type` caused new parse failures where the parser now resolved away from `tuple_type` too early. Specifically, when parsing an expression like `[(any Foo) ...`, the `tuple_type` interpretation must still be valid at that point in the expression in case we're about to see a `?`. The truly robust thing to do would be to support `$.tuple_type` as the target of the navigation expression. However, this leads to a large number of additional parse failures, as seen in #360. To avoid all of that, we add support in the opposite direction: allow `tuple_type` to be resolved using `_parenthesized_type`, so that the parser seeing the latter does not cause it to invalidate the former.
alex-pinkus
added a commit
that referenced
this pull request
Mar 3, 2024
In #353, adding `_parenthesized_type` caused new parse failures where the parser now resolved away from `tuple_type` too early. Specifically, when parsing an expression like `[(any Foo) ...`, the `tuple_type` interpretation must still be valid at that point in the expression in case we're about to see a `?`. The truly robust thing to do would be to support `$.tuple_type` as the target of the navigation expression. However, this leads to a large number of additional parse failures, as seen in #360. To avoid all of that, we add support in the opposite direction: allow `tuple_type` to be resolved using `_parenthesized_type`, so that the parser seeing the latter does not cause it to invalidate the former.
|
Fixed in #366 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.