Incorporate changes made in Helix highlight queries #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In helix-editor/helix#9586, the Helix editor added highlighting for the `any` keyword. However, while reviewing that, I noticed that both `some` and `any` should be more specific: these keywords are legal as identifiers, but should not be highlighted as identifiers when they are keywords. For instance, I can write: ``` let any: any Protocol = AnyImplementation() ``` In this example, only the second `any` should be highlighted. See discussion on #351
|
Nice catch! There's a pitch for doing something similar with I'm not sure if they're planning to convert these contextual keywords to strict keywords in future versions, or if we'll always be able to use them as variables too. Worth considering, longer term. Well spotted though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In helix-editor/helix#9586, the Helix editor added highlighting for the
anykeyword.However, while reviewing that, I noticed that both
someandanyshould be more specific: these keywords are legal as identifiers, but should not be highlighted as identifiers when they are keywords.For instance, I can write:
In this example, only the second
anyshould be highlighted.See discussion on #351.
cc @7ombie