Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix hang when the last line is a comment #160

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix hang when the last line is a comment #160

merged 1 commit into from
Apr 20, 2022

Conversation

alex-pinkus
Copy link
Owner

Fixes #159

This was the same problem as #146, where there was a while loop in the custom scanner that terminated on newlines but not on EOF. To fix, we just terminate on EOF for this loop as well.

@alex-pinkus
Fix hang when the last line is a comment
f7268fa 
Fixes #159

This was the same problem as #146, where there was a `while` loop in the
custom scanner that terminated on newlines but not on EOF. To fix, we
just terminate on EOF for this loop as well.
@alex-pinkus alex-pinkus merged commit edd2f25 into main Apr 20, 2022
@alex-pinkus alex-pinkus deleted the comment-final-line branch April 20, 2022 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Does not return result if file ends with a comment
1 participant
@alex-pinkus